CRM-21789: 'Find Case' group by issue

[monishdeb]

Overview

Steps to replicate:

1. Ensure that MySQL FULL_GROUP_BY_MODE is enabled
2. Empty submit the criteria of 'Find Cases'

Before

The actual number of rows listed and the row count per page differs. In the screencast below, only 2 rows are listed despite having 10 counts per page:

After

The actual number of rows listed and the row count per page is equal now. In the screencast below, 10 rows are listed as per 10 counts per page:

---

• CRM-21789: 'Find Case' group by issue

[monishdeb]

ping @lcdservices @eileenmcnaughton @seamuslee001

[lcdservices]

This fixes the issue. Find case search now returns the correct number of results based on the count and pagination setting (number of records to list).

[colemanw]

• (r-jira) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass: By Brian
• (r-user) Pass
• (r-tech) Pass: Test updated

[eileenmcnaughton]

So this means we are using GROUP_CONCAT rather than ANY_VALUE in the second query? My first thought looking was no no no ANY_VALUE is a hack - but I think you may be reducing the hack usage?

I am still concerned though that we are only fixing the query for mysql configs that report the query. To be clear - a query with group by is incorrect if it has fields that are in the select but not in the group by or the aggregate. Using ANY_VALUE is effectively like 'ignore this code error because we haven't managed to fix it properly or just possibly there is a real excuse for it'. Using GROUP_CONCAT is a real fix - because we know all values are returned. We shouldn't only offer the real fix for sites with mysql 5.7 or FULL GROUP BY - that's a bit like saying 'lets' fix all the e-notice identified bugs for the sites that have e-notice reporting enabled'.

I think we should be working towards dropping the if here CRM_Utils_SQL::disableFullGroupByMode()
to give the same queries in all cases. (that doesn't need to be this round but it should be our understood goal)

[monishdeb]

@colemanw thank you for merging this PR :)

@eileenmcnaughton yes I am using GROUP_CONCAT in this case. Also from our last discussion I had in mind to create a separate JIRA ticket and there will be a lot of changes in this direction and might take some time fix em all. So here's the ticket - https://issues.civicrm.org/jira/browse/CRM-21794

This is one of the priority issue for NYSS so I didn't feel that it would be appropriate to include the improvements as part of this PR.