Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/civicrm/upgrade - On finish screen, display actual version number #11705

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

totten
Copy link
Member

@totten totten commented Feb 22, 2018

Overview

This screen was hard-coded to always display the message "Thank you for upgrading to 4.7...". This patch makes it dynamic, plugging in the actual version number.

This is an incidental issue observed while working on version number realignment.

Before

On the final screen of the upgrade, it displays the message "Thank you for upgrading to 4.7...".

After

On the final screen of the upgrade, it displays the message "Thank you for upgrading to X.Y.Z...", where X.Y.Z is the actual current version number.

This screen was hard-coded to always display the message "Thank you for
upgrading to 4.7...". This patch makes it dynamic, plugging in the
actual version number.
@seamuslee001
Copy link
Contributor

seamuslee001 commented Feb 22, 2018

(CiviCRM Review Template WORD-1.0)

  • (r-jira) Pass - there is a linked issue

  • (r-test)Pass - All unit tests pass

  • (r-code) Pass - Code is nice and simple

  • (r-doc) Pass - Uses well documented smarty functions

  • (r-maint) Pass - More maintainable between versions

  • (r-run) Pass altered my local test box and changed the version number to be previous ran the upgrade through the UI and saw the version correctly outputed as per the screenshot
    civicrm upgrade success - post patch

  • (r-user) Pass has no impact on the end user

  • (r-tech) Pass uses standard function and is limited to the upgrade script

@seamuslee001 seamuslee001 merged commit 9bf49eb into civicrm:master Feb 22, 2018
@totten totten deleted the master-upgrade-ui-ver branch February 22, 2018 15:51
@totten
Copy link
Member Author

totten commented Feb 22, 2018

Thank you for reviewing and merging!

@colemanw
Copy link
Member

@seamuslee001 congrats on your first merge :)

@mlutfy mlutfy added this to the 4.7.32 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants