Fix GroupNesting, GroupOrganization, Domain to work with singleValueAlter #11689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwire
reviewed
Feb 19, 2018
| @@ -75,7 +75,6 @@ function civicrm_api3_contact_type_create($params) { | |||
| * Array of matching contact_types | |||
| */ | |||
| function civicrm_api3_contact_type_get($params) { | |||
| civicrm_api3_verify_mandatory($params); | |||
There was a problem hiding this comment.
Does mandatory params happen as part of basic get?
There was a problem hiding this comment.
it happens before it reaches that function in the api wrapper
mattwire
reviewed
Feb 19, 2018
| @@ -142,7 +142,7 @@ public static function edit(&$params, &$id) { | |||
| */ | |||
| public static function create($params) { | |||
| $domain = new CRM_Core_DAO_Domain(); | |||
| $domain->copyValues($params); | |||
| $domain->copyValues($params, TRUE); | |||
There was a problem hiding this comment.
Remind me what the second parameter does here?
There was a problem hiding this comment.
it's new - we added array handling to that function - providing the metadata is defined - new in the xml
|
@colemanw are you able to review this one? Just cleanup really |
|
This is all code cleanup on tested apis. The code looks good and the tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Standardise apis for GroupNesting, GroupOrganization, Domain and extend unit testing to cover them
Before
per overview
After
per overview
Technical Details
ContactType - $params was being overwritten (passed by reference) for no good reason
Group Nesting - did not support 'id' as a parameter. I added a create function which takes predecence over add in the api
GroupOrganization - did not really support id as a parameter. Did weird things when passed incl e-notice
Domain - now using dao metadata serialization handling
Comments
The GroupOrganization api test needed to be altered, indicating the return array was originally not correctly formatted. I feel Ok about fixing this as the format is so clearly established in general.