Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors when upgrade step already took place #11685

Merged
merged 1 commit into from
Feb 18, 2018

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Feb 17, 2018

Just ran into a hard fail in this upgrade step, so took a minute to fix it.
IMO it's best to do INSERT IGNORE when adding missing option values to avoid a hard-fail if that upgrade step has already happened.

@seamuslee001
Copy link
Contributor

This looks fine to me and has passed testing @totten @eileenmcnaughton

@eileenmcnaughton eileenmcnaughton merged commit 1d3c805 into civicrm:master Feb 18, 2018
@eileenmcnaughton eileenmcnaughton deleted the 4-7-28-up branch February 18, 2018 21:07
@mlutfy mlutfy added this to the 4.7.32 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants