CRM-21777 - Set readonly for the fields initialised in civicrm_settings.php #11680
Conversation
jitendrapurohit
changed the title
CRM/Admin/Form/Setting.php
Outdated
| @@ -95,6 +95,8 @@ public function buildQuickForm() { | |||
|
|
|||
| $descriptions = array(); | |||
| $settingMetaData = $this->getSettingsMetaData(); | |||
| //Load readonly for the input fields whose values are overridden in civicrm_settings.php. | |||
| $overriddenSettings = CRM_Utils_Array::value('civicrm_setting', $GLOBALS); | |||
There was a problem hiding this comment.
i would remove this and in 110 use something like Civi::settings()->getMandatory($setting); that should tell you if its overrriden i think iirc
There was a problem hiding this comment.
There was a problem hiding this comment.
Agreed and updated. Thanks 👍
jitendrapurohit
force-pushed
the
setting
branch
from
65faf2b
to
b6470c3
Compare
jitendrapurohit
force-pushed
the
setting
branch
from
b6470c3
to
f6c21a4
Compare
|
@jitendrapurohit I think this is same as https://issues.civicrm.org/jira/browse/CRM-21495 |
|
Looks good to me - in my test scenario I had an invalid path & the form was unsubmittable. I think it would be nicer not to validate fields in this scenario - but I acknowledge it's not necessarily something that would happen in the 'real world' merging |
| @@ -147,6 +152,9 @@ public function buildQuickForm() { | |||
|
|
|||
| } | |||
| } | |||
| if (!empty($setStatus)) { | |||
| CRM_Core_Session::setStatus("Some fields are loaded as 'readonly' as they have been set (overridden) in civicrm.settings.php.", '', 'info', array('expires' => 0)); | |||
There was a problem hiding this comment.
@jitendrapurohit This string is missing ts() for translation. Could you do a follow-up PR?
Overview
Load input fields as non-editable which have been initialized in
civicrm.settings.php.Before
Directory PreferenceORResource URLsettings initialized in civi settings file are shown as editable incivicrm/admin/setting/path?reset=1ORcivicrm/admin/setting/url?reset=1form. If a user tries to edit and update the path, it is not saved as value which is already set in civicrm.settings.php gets the preference. Check JIRA for more details.After
Fields initialized in
civicrm.settings.phpare loaded as readonly as it is of no use to load them as editable. Also, a warning is displayed which lets the user know that some fields are already set (overridden) in settings file.