Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21770: Change position of help div #11678

Conversation

mukeshcompucorp
Copy link
Contributor

@mukeshcompucorp mukeshcompucorp commented Feb 16, 2018

Overview

This PR changes position of help div like other pages in Vanilla CiviCRM

Before

image

After

image


@mattwire
Copy link
Contributor

@mukeshcompucorp Nice to see consistency improvements in CiviCRM UI. Is any of this documented anywhere as to how pages should normally be laid out? It would make it easier to review PRs such as this and also for developers/extension writers.

@mukeshcompucorp
Copy link
Contributor Author

@mattwire No, we do not have any documentation and that's why we find some of such anomalies. Actually, we don't have any documentation on how exactly a layout should be formed, so, we may need to create it at some point.

@mattwire
Copy link
Contributor

@mukeshcompucorp Ok, any chance of creating something as you submit these PRs then? Otherwise I'm worried that we'll just be playing a game of whack-a-mole as one person fixes it and another submits more UI that doesn't match what you believe is the right way. It could just be a page in the dev docs for now.
For example, from this PR, we could say that:
Normally the "Help" div should be separated from the main form div. Eg.

<div class="help">
<p>{ts}help text goes here{/ts}</p>
</div>
<div class="crm-block crm-form-block ...">
...
</div>

@mukeshcompucorp
Copy link
Contributor Author

@mattwire sure, can you point me to right repository for dev docs and I will create a page for this and submit there for further help to others.

@mattwire
Copy link
Contributor

@mukeshcompucorp I'd suggest we create a page called "UI Standards" under "Standards" https://github.com/civicrm/civicrm-dev-docs/tree/master/docs/standards. @seanmadsen @michaelmcandrew should both be able to help out with integrating a new page.

@colemanw colemanw merged commit d2bf7ff into civicrm:master Feb 16, 2018
@mukeshcompucorp mukeshcompucorp deleted the CRM-21770-change-position-of-help-div-in-export-participant branch February 23, 2018 09:30
@mlutfy mlutfy added this to the 4.7.32 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants