CRM-21759 Remove template variable as not needed and causing issues o… #11676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Joomla in 4.7.30
|
Jenkins test this please |
|
@seamuslee001 Yep that fixed it :-) Note the issue was on wordpress (though maybe Joomla too, I didn't check). It didn't seem to be a problem on drupal. |
|
@seamuslee001 I can verify the issue was present in Joomla and this fixes it. |
|
ping @totten @eileenmcnaughton i believe this should be merged now following both reviews |
|
Did a quick run on Joomla-civi instance and it worked :) Thanks @seamuslee001 for fixing this regression :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n Joomla in 4.7.30
Overview
in 4.7.30 there is a call to a non existent angular templates file. This means that the Message Templates section of a new mailing doesn't load.
Before
Message Template section doesn't load on Joomla
After
Message Template section loads
ping @eileenmcnaughton @lcdservices @monishdeb