[test only fix, new test needs altering] Change geocoder message check. #11664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be using a dummy geocoder - but since we are not let's at least check for the correct message
|
self merging as test only |
eileenmcnaughton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attempt to fix intermittent test failure
Before
Stacktrace
CRM_Utils_GeocodeTest::testGeocodeMethodOff
CiviCRM_API3_Exception: Aborting batch geocoding. Hit the over query limit on geocoder.
/home/jenkins/buildkit/build/core-11519-5wgxy/sites/all/modules/civicrm/api/api.php:45
/home/jenkins/buildkit/build/core-11519-5wgxy/sites/all/modules/civicrm/tests/phpunit/CRM/Utils/GeocodeTest.php:62
/home/jenkins/buildkit/build/core-11519-5wgxy/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:184
/home/jenkins/buildkit/bin/phpunit4:545
After
Hopefully the above won't recur
Technical Details
Comments
We should be using a dummy geocoder - but since we are not let's at least check for the correct message