Unit test fixes #11659
Merged
Unit test fixes #11659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @eileenmcnaughton |
|
@monishdeb @eileenmcnaughton Agree with this change - it restores behaviour from before #11461 but incorporates changes from #11461 too... if that makes sense! |
|
merging based on @mattwire analysis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes two of the UT failures:
CRM_Contribute_Form_ContributionTest::testReSubmitSaleTaxAlteredAmount with data set #0 ('.')
Failed asserting that '1000.00' matches expected 2000.
CRM_Contribute_Form_ContributionTest::testReSubmitSaleTaxAlteredAmount with data set CRM-11926 Improve error message on APi failure to include DB error message #1 (',')
Failed asserting that '1000.00' matches expected 2000.
Occurred after #11461 was merged, which is a bit strange that those 2 failures doesn't get picked up on its test build