Fix unit test to not rely on hacking the DB to have ids for price set…

[eileenmcnaughton]

Overview

Fix test to be more robust regarding set up & tear down

Before

Test relies on some pretty hacky DB manipulation

After

Test works on 'neutral' DB state

Technical Details

I added 'another' function for getting the line item array since none of the ones that existed seemed to be 'neutral' / logical & I feel we need to start deprecating them in favour of something more thought through. The code for building line items & processing them is notably hard to read & fragile (perhaps not surprising as much of it was done in 4.2)

I would argue that if we know the field & the submitted value (e.g price_4 => 6) we have all the information we need to build the params. If the calling function is relying on a default priceset then this call could be wrapped in something that reformats to the standard price set params. Aim to replace getLineItemArray - or at least the first half of it with this function

Comments

Removes blocker to test config changes in #11646

[monishdeb]

Nice work :) merging now

[eileenmcnaughton]

we'll just have to keep working on line item function rationalisation - my thinking is write something better & migrate to it - but you might have other ideas