CRM-21675: scheduled reminders: limit to group doesn't support parent groups

[monishdeb]

Overview

Currently, you can not include recipients of parent group and its child group but can choose only 1 regular or smart group to limit recipients of schedule reminder. This fix extends the support to include all the recipients of parent and its child group(s).

Before

Doesn't include all recipients of parent and its child group(s)

After

Include all recipients of parent and its child group(s)

Technical Details

The PR got unit test for this fix

---

• CRM-21675: scheduled reminders: limit to group doesn't support smart groups

[monishdeb]

Marked as [WIP] as going to add additional criteria and fixed in the new unit test

[monishdeb]

ping @lcdservices @eileenmcnaughton @seamuslee001

[lcdservices]

@monishdeb this looks good. When restricting to a parent group in scheduled reminders, members of child groups are included (and delivered to).

[monishdeb]

Jenkins test this please

[eileenmcnaughton]

@totten are you able to take a look at this? It makes sense to me in the general logic & it has a test but it's code only really you @monishdeb & @jitendrapurohit have looked at.

OTOH it has a unit test & it has been r-run tested by @lcdservices too

[jitendrapurohit]

Tested normal and smart groups with sched reminder and confirm that parent group includes all child group contacts correctly as expected.

[colemanw]

• (r-explain) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass: Tested by @jitendrapurohit and @lcdservices
• (r-user) Pass
• (r-tech) Pass: Includes tests

[eileenmcnaughton]

yay

[monishdeb]

Thanks everyone :)

[mcollopy]

Hi - I've experienced a problem with a 'limit to' Smart group which was a complex Include/Exclude group based on Membership expiry dates among other criteria.
Just wondering if whether there's a limit to the complexity of the Smart Group, being only simple contact criteria, and not complex multi table criteria.
I believe we've had this working based on Smart groups using relationships, but perhaps Memberships is not achievable.
See related issue here https://issues.civicrm.org/jira/browse/CRM-21675