CRM-21316 Additional fix. Set default provider when creating SMS.

[JKingsnorth]

Fix a regression in CRM-21316 whereby the recipients for a mass SMS are not build correctly. This is because the SMS provider is not set when the getRecipients function is called.

As discussed in #11558

---

• CRM-21316: Refactor getRecipients fn by creating a new fn getMailRecipients, that will be used ONLY to fetch and store mail recipients

[JKingsnorth]

@eileenmcnaughton @monishdeb As discussed in #11558 this is the last fix for the regressions in the mailing tool.

[eileenmcnaughton]

@monishdeb do we need this in the rc?

[monishdeb]

Yeah, actually this is a regression as explained in the 3rd point of this comment where due to refactoring we don't pass any $mode = sms/mailing parameter to fetch recipients. Now the only decisive factor that tell BAO function, about its mode is the $mailingObj->sms_provider_id

However, as per the patch is concern, I differ a bit. Since now sms_provider_id is a crucial attribute to fetch recipients, why can't we make this field required and move the set-default code from postProcess to setDefaults ?

So I will be going to create a 4.7.31-rc PR for this.

[eileenmcnaughton]

@monishdeb branching has not happened yet - got late & tim will do in the morning so depending on timing / confidence it will be master

[monishdeb]

cool .. then let me submit a PR shortly against master :D

[monishdeb]

I have submitted a PR #11656 with alternative solution. Please have a look

[eileenmcnaughton]

@JKingsnorth @monishdeb the alternate was merged - do we still want this one?