(NFC) Fix logging test for multilingual on MySQL5.7 #11626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There does not seem to be any loss of test coverage here & it is test-only - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
At present CRM_Logging_LoggingTest is failing on Ubu1604 which runs MySQL 5.7. This is because the multilingual view is still referencing a column that has now been deleted from the base table and MySQL 5.7 is a bit more stricter on this. This fixes the test and improves the test a little.
Before
Test fails on ubu1604-1
After
Test passes on MySQL 5.7
ping @mlutfy @totten @eileenmcnaughton