Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21729 exclude vendor .idea, test-cases, unit-test from deployment #11613

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 31, 2018

Overview

Exclude some (more) vendor test files from our deployment

Before

unit-tests, test-cases & .idea folder from phpquery package are in our deployment

After

Above test files do not ship with our product

Technical Details

This came to my attention because one of the files is not passing lint. We are already excluding other similar folders

Comments

Upstream PR electrolinux/phpquery#13


@JoeMurray
Copy link
Contributor

So this is a very good initiative.

@totten
Copy link
Member

totten commented Jan 31, 2018

Tested locally by running distmaker. Observed:

  • Previous tarballs (before the patch) included the extraneous support files from phpquery
  • New tarballs (with the patch) include phpquery -- but correctly omit extraneous support files
  • distmaker runs without reporting any new/obvious errors

@totten totten merged commit 9fe9f64 into civicrm:master Jan 31, 2018
@mlutfy mlutfy added this to the 4.7.31 milestone Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants