CRM-21711 When updating multiple memberships thru a contribution page custom fields are only updated on one #11586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test this please |
alifrumin
changed the title
|
There are tests for that form submission in CRM_Contribution_Form_ContributeTest - would be good to get a test on it |
alifrumin
changed the title
|
@alifrumin when you finish writing the test could you please rebase & squash the commits on this PR into one commit? That will also get rid of that pesky merge commit that snuck in. Thanks. |
alifrumin
force-pushed
the
CRM-21711
branch
3 times, most recently
from
7f3e80f to
49492bb
Compare
alifrumin
changed the title
|
Jenkins test this please |
|
@jitendrapurohit pls review |
|
@alifrumin any chance you could do @jitendrapurohit's one in return? #10496 (it's pretty straight forward - probably only about 20 mins to do) |
|
Happy to I will look at it now |
jitendrapurohit
approved these changes
Mar 21, 2018
|
Merging based on @jitendrapurohit's testing. Code looks sensible & I detect a minor clean up plus.... UNIT TEST |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If a user is renewing multiple memberships on one contribution page and that contribution page also has a profile with custom fields on the membership the custom fields are only updated on one membership when they should be updated on all.
Before
When you are renewing or creating multiple memberships thru a front facing contribution page custom fields are only updated on one membership.
After
When you are renewing or creating multiple memberships thru a front facing contribution page custom fields are updated on ALL memberships.
Technical Details
moves the updating of custom fields into the foreach
Comments
I intend to write a test for this as a part of a separate pr