Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21708: Fixed page structure by adding/removing classes #11585

Merged
merged 2 commits into from
Feb 15, 2018
Merged

CRM-21708: Fixed page structure by adding/removing classes #11585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c1403
CRM-21708: Fixed page structure by adding/removing classes
mukeshcompucorp Jan 25, 2018
2731695
CRM-21708: Removed unwanted IDs
mukeshcompucorp Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/CRM/Admin/Page/ConfigTaskList.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
{capture assign="linkTitle"}{ts}Edit settings{/ts}{/capture}
{capture assign="adminMenu"}{crmURL p="civicrm/admin" q="reset=1"}{/capture}

<div id="help" class="description">
<div class="help">
{ts 1=$adminMenu}Use this checklist to review and complete configuration tasks for your site. You will be redirected back to this checklist after saving each setting. Settings which you have not yet reviewed will be <span class="status-overdue">displayed in red</span>. After you have visited a page, the links will <span class="status-pending">display in green</span> (although you may still need to revisit the page to complete or update the settings). You can access this page again from the <a href="%1">Administer CiviCRM</a> menu at any time.{/ts}
</div>

Expand Down
2 changes: 1 addition & 1 deletion templates/CRM/Admin/Page/MessageTemplates.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
</div>
</div>

<div id="crm-submit-buttons">{$form.buttons.html}</div>
<div id="crm-submit-buttons" class="crm-submit-buttons">{$form.buttons.html}</div>
</fieldset>
{/if}

Expand Down
2 changes: 1 addition & 1 deletion templates/CRM/Contact/Form/Search/Builder.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
{* Table for adding search criteria. *}
{include file="CRM/Contact/Form/Search/table.tpl"}
<div class="clear"></div>
<div id="crm-submit-buttons">
<div id="crm-submit-buttons" class="crm-submit-buttons">
{$form.buttons.html}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion templates/CRM/Event/Form/Registration/AdditionalParticipant.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
{include file="CRM/UF/Form/Block.tpl" fields=$additionalCustomPost}
</div>

<div id="crm-submit-buttons">
<div id="crm-submit-buttons" class="crm-submit-buttons">
{include file="CRM/common/formButtons.tpl"}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion templates/CRM/Event/Form/Registration/ParticipantConfirm.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
{$statusMsg}
</div>

<div id="crm-submit-buttons">
<div id="crm-submit-buttons" class="crm-submit-buttons">
{include file="CRM/common/formButtons.tpl" location="bottom"}
</div>
</div>
4 changes: 2 additions & 2 deletions templates/CRM/Event/Import/Form/MapField.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<table class="form-layout">
<tr>
<td>
<div id="crm-submit-buttons">
<div class="crm-submit-buttons">
{include file="CRM/common/formButtons.tpl" location="top"}
</div>
</td>
Expand All @@ -51,7 +51,7 @@
</tr>
<tr>
<td>
<div id="crm-submit-buttons">
<div class="crm-submit-buttons">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why some buttons have class and id and some only class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradpnayak that's structuring issue. We are trying to identify and fix any such bugs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradpnayak no reply from your end, should we move ahead and merge it?

{include file="CRM/common/formButtons.tpl" location="bottom"}
</div>
</td>
Expand Down
2 changes: 1 addition & 1 deletion templates/CRM/Export/Form/Select.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
<div class="crm-section crm-export-mergeOptions-section">
<div class="label crm-label-mergeOptions">{ts}Merge Options{/ts} {help id="id-export_merge_options"}</div>
<div class="content crm-content-mergeOptions">
&nbsp;{$form.mergeOption.html}
{$form.mergeOption.html}
</div>
<div id='greetings' class="content crm-content-greetings class='hiddenElement'">
<table class="form-layout-compressed">
Expand Down
2 changes: 1 addition & 1 deletion templates/CRM/Grant/Form/Selector.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
{strip}
<table class="selector row-highlight">
<thead class="sticky">
<tr class="columnheader">
<tr>
{if ! $single and $context eq 'Search' }
<th scope="col" title="Select Rows">{$form.toggleSelect.html}</th>
{/if}
Expand Down