CRM-21667: Fixed timezone handoff from Drupal6. #11534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code looks good to me, and makes sense...I still have one D6 site I can look at :) |
|
Thanks for reviewing it, @jackrabbithanna. Now how the heck do we get it merged -- I always seem to have trouble with that part. |
|
Merging #11534 |
|
Well, it helps to have commit rights. Thanks! |
|
Whoops, looks like we didn't get DST right. See #11800. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves errors resulting from representation of timezone data in different formats.
Before
One place this error can manifest is on the status screen (civicrm/a/#/status). The Angular frame will load with no content.
The error can also be reproduced by visiting the API explorer and doing api.system.check. The output will be something like:
After
Timezone data is converted from GMT offset in seconds to region string, as expected by related methods.
Technical Details
Nothing noteworthy here.