CRM-21629 System Check: Set User Agent to security filters accept check

[tommybobo]

Overview

Set User Agent for the code that performs System Check of Resource URL. Security filters often block clients with blank User Agents. This code set the User Agent to CiviCRM.

Before

Current checks show up as user agent "-". Which results in a blocked connection on some sites, and results in a false positive check.

After

The check goes through as it should if filters are in place.

• CRM-21629: Resource URL status check gets false positive when blank user agents are blocked

[seamuslee001]

Jenkins re test this please

[mlutfy]

Seems good to me.

@MegaphoneJon You mentioned on JIRA having run into this issue as well. Can you test the patch?

[MegaphoneJon]

I replicated the problem (with iThemes Security for WordPress), confirmed this patch fixes the problem. I also reviewed the code and think this is correct.

[mlutfy]

(CiviCRM Review Template WORD-1.0)

• (r-jira) ✔
• (r-test) ✔
• (r-code) ✔
• (r-doc) ✔ n/a
• (r-maint) ✔
• (r-run) ✔ Tested by Jon
• (r-user) ✔ n/a
• (r-tech) ✔ not ideal, but since it's calling get_headers directly, instead of using a class/lib, not worth obsessing over it.