CRM-21595 re-fix CRM-21445

[eileenmcnaughton]

Overview

Revert https://github.com/civicrm/civicrm-core/pull/11427/files
Add additional check for pay later fatal

#11454 against 4.7.30 - due to the criticality of this I am merging to 4.7.30 & up to master now - although I still advocate replacing the 4.7.29 release ASAP

---

• CRM-21595: Regression: Contribution page no longer works when configured with PayPal Pro and pay later
• CRM-21445: Contribution page issues with 100% discount

[a-irvine]

Thank you. This patch has fixed WSOD and saved me many hours of reverting backups.

[dandoran-wp]

Yes, thank you! A client of ours is using Auth.net payment processor, and I implemented this patch and avoided WSOD in one case.

However, we are still seeing WSOD when a user tries to access Batches. Any ideas?

[eileenmcnaughton]

@dandoran-wp sounds like a different issue - do you have access to error log to look for clues?

[dandoran-wp]

Yes, I have. Debugging is enabled. Nothing is written to the log. The webserver log says:

FastCGI sent in stderr: "PHP message: PHP Fatal error: Call to undefined method CRM_Batch_BAO_Batch::checkBatchPermission() in /home/forge/coloradononprofits.org/public/sites/all/modules/civicrm/CRM/Financial/Form/Search.php on line 103" while reading response header from upstream, client: 67.88.124.26, server: coloradononprofits.org, request: "GET /civicrm/financial/financialbatches?reset=1&batchStatus=1 HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php5.6-fpm.sock:", host: "www.coloradononprofits.org", referrer: "https://www.coloradononprofits.org/civicrm/contact/search/advanced?_qf_Select_display=true&qfKey=2ce93f24ef589281c4ad4cefedd5f7d8_4134"

[dandoran-wp]

Okay, I found the issue -- it's in an extension of JMA Consulting's. Thank you for your help.

[eileenmcnaughton]

Ah - yeah I was thinking it looked like there was an extension php override in place :-(