CRM-20676: Tax applied repeatedly on edits of price set events #11455
Conversation
| 'id' => $params['id'], | ||
| 'return' => 'tax_amount', | ||
| )); | ||
| } |
There was a problem hiding this comment.
@Monish I'm curious to know why this is necessary. The old code was referencing this variable already, just as the new code is. Was it sometimes not present?
There was a problem hiding this comment.
@colemanw for the added unit test it needs default tax_amount information in $this->_values, but unfortunately Contribution.getsingle API doesn't provide value for this attribute, so yes its something not present earlier and there was no UT written, that need tax_amount (until now). Another alternative to deal with it is to set this as one of the default return property as I did here But after discussing with Eileen I decided to fetch its value on demand.
|
I had a similar issue on a client site, affecting edits of contributions. To fix, I had to apply this patch and also #11461 |
|
Merged - this is a tested step forwards - but we need to also check if we need #11461 |
CRM-20676: Tax applied repeatedly on edits of price set events
Overview
https://civicrm.stackexchange.com/questions/18887/saving-a-contribution-adds-a-line-with-negative-the-tax-amount-when-using-an-ev
Before
After