CRM-21591 Add Test of formatUnitSize Function #11447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seamuslee001
force-pushed
the
CRM-21591
branch
from
6196f1f to
20a3084
Compare
|
@seamuslee001 is this test meant to fail until the other PR is merged? |
|
@colemanw no is meant to pass. what it is meant to do is verify that after applying that other PR the function still returns the same values. |
|
Cool. If we don't get a rebase on that other PR from the OP could you just cherry pick it into this one? |
|
jenkins, test this please (I'm testing the C-I upgrade, previous check had passed) |
|
This is a test & it passes - merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds a unit test of the function CRM_Utils_Number::formatUnitSize. It aims to validate the fix for CRM-21591 in this PR https://github.com/civicrm/civicrm-core/pull/11429/files
Before
Function not tested
After
Function tested
ping @colemanw @eileenmcnaughton @totten