CRM-21551 Add parameter to support skipping processing greetings when… #11405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calling api contact.create
eileenmcnaughton
force-pushed
the
removal
branch
from
b1b6978 to
d29b0fe
Compare
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21551 Add parameter to support skipping processing greetings when…
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Jan 10, 2018
Note we need some (already upstreamed) civicrm fixes merged + progress on this civicrm/civicrm-core#11405 before the tests will pass. I propose that we actually DON'T skip processing greetings when the amount is $500+ because it would benefit major gifts if that were set. Bug: T156193 Change-Id: I7c34be4225c04ac112d74891035607144178fd5f
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Jan 10, 2018
Note we need some (already upstreamed) civicrm fixes merged + progress on this civicrm/civicrm-core#11405 before the tests will pass. I propose that we actually DON'T skip processing greetings when the amount is $500+ because it would benefit major gifts if that were set. Bug: T156193 Change-Id: I7c34be4225c04ac112d74891035607144178fd5f
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Feb 1, 2018
… calling api contact.create civicrm#11405 This allows unit tests in the extension to run for us & on stock & brings us closer to stock Bug: T156193 Change-Id: Ib99a659495b7c584a986d056d53667b23f62494c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add parameter to support skipping processing greetings when calling api contact.create
Before
Not possible to skip this often slow function when processing large batches.
After
Possible to skip greeting processing. Can be done later by scheduled job
Technical Details
We have a precedent for allowing intensive operations to be skipped when being called from the api - ie. currently geocoding and street parsing can be skipped and filled by offline jobs. There is a PR open to allow skipping the mystical and magical fixAddress function https://github.com/civicrm/civicrm-core/pull/11372/files and the processGreeting code is in a similar vein ie 1) expensive to run and 2) there is a job which can do it 'out of hours' if decided.
Adding another 'magic param' to the v3 api is not great but OTOH there is sufficient precedent IMHO