Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19704: mailing body stripped if image only #11399

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Dec 12, 2017

Overview

Adding an image only in mailing HTML content and on preview its show null.

Before

screen shot 2017-12-12 at 9 33 28 pm

After

Adds image correctly

Technical Details

This is a regression due to #8145 fix, where it strips all html tags. As per fix I have allowed <img>


@monishdeb
Copy link
Member Author

ping @colemanw @lcdservices

@lcdservices
Copy link
Contributor

Looks good. The body of the email can now contain just an image.

@colemanw
Copy link
Member

Code looks good. Merging based on @lcdservices review.

@colemanw colemanw merged commit 931760a into civicrm:master Dec 12, 2017
@monishdeb monishdeb deleted the CRM-19704 branch December 12, 2017 18:13
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-19704: mailing body stripped if image only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants