CRM-21531 - replace regex with POSIX-compliant alternative for MariaD… #11388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eileenmcnaughton @monishdeb i feel like both of you have had some experience with this stuff |
|
Yeah - pretty sure that line has bounced back & forwards a few times :-) - perhaps git blame will provide the reasons |
|
The git history suggests that @jitendrapurohit or @monishdeb might have some thoughts on the regex in this file. FWIW, code/explanation seems reasonable. @MegaphoneJon , it sounds like you've |
|
To ensure its safe to merge I tested against MySQL and it worked for me. I am happy with this patch, merging now :) Referred https://mariadb.com/kb/en/library/regular-expressions-overview/# |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21531 - replace regex with POSIX-compliant alternative for MariaD…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…B compatibility
Overview
MySQL and MariaDB use different regex libraries. Certain non-POSIX regex statements will cause MariaDB to fail to execute a query, crashing CiviCRM. See https://jira.mariadb.org/browse/MDEV-7127 for details.
Before
Searching for a multi-select custom field value that contained a parenthesis would succeed on MySQL and fails on MariaDB with the error: "POSIX collating elements are not supported".
After
The search succeeds on both MySQL and MariaDB.