Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21526: CRM_Utils_System_Drupal8::authenticate() should change the Drupal user #11381

Merged
merged 1 commit into from
Dec 9, 2017

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Dec 6, 2017

@eileenmcnaughton
Copy link
Contributor

@jackrabbithanna if you think this looks right I'm good to merge it (or for you to)

@jackrabbithanna
Copy link
Contributor

Code looks right, and think lets merge this so we can continue to flesh out the rest of the issue.
merging #11381

@jackrabbithanna jackrabbithanna merged commit 9a61e37 into civicrm:master Dec 9, 2017
@dsnopek
Copy link
Contributor Author

dsnopek commented Dec 9, 2017

Thanks!!

@jackrabbithanna
Copy link
Contributor

This month is the month to bring in all the updates you have into the Drupal module and CiviCRM Core....I have some company authorized time to do reviews, testing, and help with issues, and some personal time too....If you want to make a big push this month, lets do it!

@dsnopek
Copy link
Contributor Author

dsnopek commented Dec 9, 2017

We can for sure try! It's kind of a short month, given that the 2nd half is eaten up by holidays, but we can try and make the most of next week :-)

@jackrabbithanna
Copy link
Contributor

Great, make what PRs you can next week, and I'll be reviewing them over the next weekend and over the holidays

@colemanw
Copy link
Member

colemanw commented Dec 9, 2017

@jackrabbithanna @dsnopek I'd like to schedule a call for anyone interested in D8 packaging to discuss the way forward with composer. @totten & I briefly discussed it last week and we think creating a new repo for the D8-civicrm code is the best solution for the version number problem that's currently blocking us (composer doesn't recognize the format 8.x-4.x). So let's hash that out and any other issues wrt composer and carve a path forward.

@jackrabbithanna
Copy link
Contributor

@colemanw sounds good to me, available most days from 10-2:45 central time, and then in the evenings

@dsnopek
Copy link
Contributor Author

dsnopek commented Dec 11, 2017

@colemanw Sure! Just let me know :-)

sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-21526: CRM_Utils_System_Drupal8::authenticate() should change the Drupal user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants