-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-21225: Added a new field, Profile Title so that the Profile Name does not serve a dual purpose of labelling the Profile and displaying the Title for the Profile fields publicly. #11370
Conversation
f85c668
to
9439e9c
Compare
Hi @jusfreeman There are a few issues here 1. the xml file changes aren't included nor are the changes to sql/civicrm_generate.sql also doing upgrade testing i was finding that this wasn't properly adding the fields in multilingual situation. It also showed a bug in the code as well. I have addrsssed all the issues here seamuslee001@0a4bb57577 |
Thanks @seamuslee001 I'll ask @agilewarealok to review. |
… on public pages.
9439e9c
to
b51b9f4
Compare
I'm in favour of this schema change. I haven't reviewed patch. |
@seamuslee001 any idea why the build is failing for this PR? The link to the build report is broke. |
@jusfreeman i think it may have been conflict or something. I have started work on getting the schema changes through as needed here #11503 |
@seamuslee001 great thanks, will you be able to manage this PR to final merge? Or do we need to do more stuff with it? |
@jusfreeman i'll try and manage this one through, there was some chatter on the isssue on MM this morning to resolve the naming of the new column which should be done now |
Discussed this a bit on Mattermost with Eileen and Seamus. On general principle, I agree there's utility in splitting apart the profile Those comments aren't a full review, though -- a full review would, e.g., need to |
@seamuslee001 thanks mate, appreciated. @totten we weren't really thinking of changing all backend/admin forms, just dealing with the profile use case. Wary of expanding the scope too much and putting noses out of joint. The original issue description, use case is what we're trying to solve here. I'll leave this one in your respective safe hands :) Thanks! |
Closing this one as similar PR(#11508) is merged into master. |
Overview
Add a new field, Profile Title so that the Profile Name does not serve a dual purpose of labelling the Profile and displaying the Title for the Profile fields publicly.
The use case is when you want a Profile to have a name which is used internally and describes how the profile is being used but want to use a different title when the profile is embedded on a contribution, event etc.
eg. "Top secret donors" = Profile Name, versus "Enter your donation details" = Profile Title
Agileware Ref CIVICRM-506
Before
Profiles had only single field to show internally and publicly.
After
Now profiles have name as well as title, we are using display title for displaying the Title for the Profile fields publicly.
Agileware Ref: CIVICRM-506