CRM-21518: Added missing containers to template #11369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshcompucorp
changed the title
2 tasks
colemanw
requested changes
Dec 5, 2017
| @@ -66,4 +68,5 @@ | |||
| {crmButton q="action=add&reset=1" icon="plus-circle"}{ts}Add Contact Type{/ts}{/crmButton} | |||
| {crmButton p="civicrm/admin" q="reset=1" class="cancel" icon="times"}{ts}Done{/ts}{/crmButton} | |||
| </div> | |||
| </div> | |||
| {/if} | |||
There was a problem hiding this comment.
It looks to me like the opening of the div tag is outside the {if} clause but the closing tag is inside the {/if}
There was a problem hiding this comment.
This was looking like it due to malformed spacing. I fixed it. Now it should look good.
| @@ -69,3 +70,4 @@ | |||
| {crmButton p="civicrm/admin" q="reset=1" class="cancel" icon="times"}{ts}Done{/ts}{/crmButton} | |||
| </div> | |||
| {/if} | |||
| </div> | |||
There was a problem hiding this comment.
need a newline at the end of this file
There was a problem hiding this comment.
@colemanw added
colemanw
approved these changes
Dec 6, 2017
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
…min-pages CRM-21518: Added missing containers to template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds missing container classes in templates which are missing.
Screenshots
This PR does not modify anything of visual difference. The idea here is to allow any other theme (Shoreditch in this context or any other in future) to have unified UI/UX solution if they use such class.
Comments
This is tested with default styling of CiviCRM and custom theme Shoreditch