CRM-21508 Fix column Information for civicrm_mailing.created_date pas…

[seamuslee001]

…sed to Docker When

Overview

When there was locking mechanisms attached to the civicrm_mailing table to prevent duplicate windows editing mailings. the created_date column was changed to default to NULL to satisfy older MySQL versions. This was not properly updated in the Docker When information array.

Before

Docker When Fails to convert tables

After

Tables convert correctly

Technical Details

As part of 4.7.27 We converted the created_date column to be DEFAULT NULL so we could have a modified_date column which was ON UPDATE CURRENT_TIMESTAMP see https://github.com/civicrm/civicrm-core/blob/master/CRM/Upgrade/Incremental/php/FourSeven.php#L449 and https://github.com/civicrm/civicrm-core/blob/master/CRM/Upgrade/Incremental/php/FourSeven.php#L1382 However in the Timestamps.php array the default of CURRENT_TIMESTAMP was still set which caused this issue civicrm/org.civicrm.doctorwhen#10

Comments

ping @totten @eileenmcnaughton @MegaphoneJon I believe this is the solution to the problem, I have put it against the RC as it was a bug in 4.7.27

• CRM-21508 civicrm_mailing.created_date information passed to Doctor When is incorrect

[eileenmcnaughton]

Docter When not Docker When?

[eileenmcnaughton]

I checked and I agree that NULL rather than CURRENT_TIMESTAMP is the correct default for the created_date field. This change will only affect people converting those fields using Doctor When so the risk factor is low here and it does seem like the correct fix for a valid error - merging