CRM-21471 remove unused core function CRM_Core_Pseudoconstant::greeti… #11313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+11 -75 SLOC! |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21471 remove unused core function CRM_Core_Pseudoconstant::greeti…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ngDefaults
Overview
Removed function that is never called. Grepped codebase & searched google to check for other instances. (I think doing a google search is a reasonable surrogate for the universe check which requires a lot of downloading & disk space)
It turns out the actually used function is CRM_Contact_BAO_Contact_Utils::defaultGreeting
Technical Details
On review I find the function CRM_Core_Pseudoconstant::greetingDefaults to be called from only one place:
CRM_Core_PseudoConstant::processGreetings
It is only called if the value $useDefaults is passed in. CRM_Core_PseudoConstant::processGreetings is called from one place and $useDefaults is NOT passed in