Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21454 Add money raised on page contribution widget ajax response #11299

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

francescbassas
Copy link
Contributor

@francescbassas francescbassas commented Nov 19, 2017

Overview

A brief description of the pull request. Try to keep it non-technical.

Before

The current status. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

After

What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

Anything else you would like the reviewer to note


@eileenmcnaughton
Copy link
Contributor

eileenmcnaughton commented Nov 21, 2017

(CiviCRM Review Template WORD-1.0)

I'm going to merge this on balance. In most ways it's pretty harmless - it just exposes another piece of data that has been fetched to the ajax call. My reservation about this is that without a unit test this should be seen as an unsupported or best effort interaction with core. Some one could make changes later that stopped it from working again and that needs to be all on the extension writer, not on core.

However, I think given the triviality of it it's OK to let this through

@eileenmcnaughton eileenmcnaughton merged commit 2d6066c into civicrm:master Nov 21, 2017
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-21454 Add money raised on page contribution widget ajax response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants