CRM-21362: followup PR which fixes duplicate mailing rows for each job #11261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the mailing summary report result list when date fields are selected for display. Prior to this patch, if you chose to display a date field the report was grouped by the date (in order to be in compliance with the MySQL 5.7 group by requirements), which caused mailings that were split into more than one job to be listed multiple times (the dates are extracted from the job records). This fixes the issue so mailings are listed only once. @colemanw can you review and merge. |
|
Code looks good to me. I trust Monish's work and Brian's review; merging. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21362: followup PR which fixes duplicate mailing rows for each job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a followup PR of #11206 which fixes duplicate mailing rows for each job.