CRM-20358: Fix WordPress Access Control table

[christianwach]

Overview

Unifies the separate tables on the WordPress Access Control page into a single table. This fixes CRM-20358 by ensuring that the table rows line up.

Before

After

[christianwach]

Please notify me of the versions of CiviCRM (both 4.7.x and 4.6.x if back-ported) that this gets applied to so that I can disable the fix in the CiviCRM Admin Utilities plugin. Thanks!

[seamuslee001]

ping @agileware @jusfreeman @agilewarealok can one of you review this?

[christianwach]

@seamuslee001 Oops, branch confusion. Have just added a commit that fixes missing rows. Layout is unaffected.

[christianwach]

Dang it, stray capitalised as. @seamuslee001 Would you prefer me to close this and open a new PR with code that passes the tests?

[jusfreeman]

@seamuslee001 just ping me for PRs like this. No need to knock on all doors buddy :-)

[seamuslee001]

@christianwach just stay on this one PR but i would suggest git fetch <civi core alias> && git rebase -i <civi core alias>/master and squish the commits into 1

[christianwach]

@seamuslee001 Thanks for the advice. Hope I've done it right :-)

[totten]

(CiviCRM Review Template WORD-1.0)

• (r-jira) Pass
• (r-test) Pass
• (r-code) Pass(*), but I only skimmed
• (r-doc) Pass
• (r-maint) Pass(*): There's no test-coverage for this screen, but that's a pre-existing problem. We just test manually.
• (r-run) Pass: The patch changes some of the mechanics of the screen, so my goal was to get confirmation from another source (eg wp-cli) that it worked as expected.
  • Applied the patch
  • Navigated to the screen. Added some new Civi-related permissions to "Contributor".
  • Ran wp cap list contributor to see the new permissions. Found the additions were applied.
  • Used the screen again. Saw the permissions were still enabled. Removed a few of the permissions.
  • Ran wp cap list contributor to see the new permissions. Found the removals were applied.
• (r-user) Pass: Drop-in cleanup/fix for UI
• (r-tech) Pass: Fixes UI/presentation. Works with WP data-model.