CRM-17860, CRM-18231 - JobProcessMailingTest - Re-remove require_once #11251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview -------- Remove an unnecessary line from test suite. Before ------ The test worked when executed as part of the `api_v3` suite, but it failed when run individually (because the `require_once` doesn't work). Moreover, the tests for `org.civicrm.flexmailer` failed After ----- The tests work on their own. Comment ------- This change deals entirely with the packaging/framing of a test-case. It neither (a) involves the runtime behavior of the application nor (b) the semantics/behavior of the test. Consequently, it should be safe to merge as long as the test-runner remains happy.
|
Happy that tests pass makes sense to me. If it means more testing of extensions then all for it |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-17860, CRM-18231 - JobProcessMailingTest - Re-remove require_once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove an unnecessary line from test suite.
This was previously removed by CRM-17860. I think it got up incidentally in a long-running PR for CRM-18231 and then re-added (unnecessarily, IMHO).
Before
The test worked when executed as part of the
api_v3suite, but it failedwhen run individually (because the
require_oncedoesn't work). Moreover,the tests for
org.civicrm.flexmailerfailed for the same reason.After
The tests work on their own.
Comments
This change deals entirely with the packaging/framing of a test-case. It
neither (a) involves the runtime behavior of the application nor (b) the
semantics/behavior of the test. Consequently, it should be safe to merge as
long as the test-runner remains happy.