CRM-20545 - Fix more reports to exclude deleted contacts

[colemanw]

• CRM-20545: contact report lists contacts that have been 'soft' deleted (placed in Trash)

[eileenmcnaughton]

I tested this on the Contribution Detail report & the is_deleted filter was added which I think makes sense (I think an argument could be made against it but it's probably a bit obscure & not that strong) but the is_deceased filter was also applied and I don't think that makes sense for contributions - ie. we still got their money. I'm kinda inclined to bring across the methodology from the ExtendedReport extension here - which has a getColumns function which then grabs & filters the metadata relating to entities. (the function being used here was originally ported from that extension but has altered a little since I think)

[colemanw]

Ah good catch. You're right we shouldn't exclude deceased contacts from (probably most) reports.

[eileenmcnaughton]

I put up the extended reports approach as an alternate (just for one report + the ones that don't use it) - it seems wordy since it adds a few functions, but I've been slowly developing the approach over quite a period & it has been allowing me to tidy up the individual reports in extended reports