CRM-21364 Non controversial fixes for ONLY_FULL_GROUP_BY and NO_ZERO_… #11219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monishdeb
approved these changes
Nov 1, 2017
There was a problem hiding this comment.
Reviewed and tested the patch, works fine for me. @eileenmcnaughton can you review and merge the code, esp. the changes made in CRM/Activity/BAO/Activity.php that I suggested earlier.
|
@Eileen are you ok with this? |
seamuslee001
force-pushed
the
test-fixes-full
branch
from
f7aed9a to
7d3b1a9
Compare
|
@monishdeb tests have passed |
|
Happy with the final patch.. merging now |
mattwire
reviewed
Nov 8, 2017
| // The activityTempTable contains the sorted rows | ||
| // so in order to maintain the sort order as-is we add an auto_increment | ||
| // field; we can sort by this later to ensure the sort order stays correct. | ||
| $sql .= " fixed_sort_order INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,"; | ||
| foreach ($tableFields as $name => $desc) { | ||
| $sql .= "$name $desc,\n"; | ||
| $insertValueSQL[] = $name; | ||
| if ($name == 'source_contact_name' && CRM_Utils_SQL::supportsFullGroupBy()) { | ||
| $selectColumns[] = "ANY_VALUE(tbl.$name)"; |
There was a problem hiding this comment.
@seamuslee001 ANY_VALUE does not exist on mariadb (https://jira.mariadb.org/browse/MDEV-10426) so including it here prevents us using mariadb. Just hit this while saving a new membership
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21364 Non controversial fixes for ONLY_FULL_GROUP_BY and NO_ZERO_…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…DATE sqlModes
Overview
This pulls out the non controversial fixes from https://github.com/civicrm/civicrm-core/pull/11053/files and #11207. ping @monishdeb @eileenmcnaughton @colemanw
This aims to fix some test failures on the unbuntu1604 matrix