CRM-21364 Fix upgrades from 4.2.x for ONLY_FULL_GROUP_BY compatability #11209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seamuslee001
commented
Oct 29, 2017
| @@ -613,7 +613,7 @@ public static function task_4_2_alpha1_convertContributions(CRM_Queue_TaskContex | |||
| LEFT JOIN civicrm_price_set_entity cpse on cpse.entity_table = 'civicrm_contribution_page' AND cpse.entity_id = cc.contribution_page_id | |||
| WHERE (cc.id BETWEEN %1 AND %2) | |||
| AND cli.entity_id IS NULL AND cc.contribution_page_id IS NOT NULL AND cpp.contribution_id IS NULL | |||
| GROUP BY cc.id | |||
| GROUP BY cc.id, cmp.membership_id | |||
There was a problem hiding this comment.
I'm fairly certain this will have no major issues
seamuslee001
commented
Oct 29, 2017
| @@ -782,8 +782,7 @@ public function createFinancialRecords() { | |||
| AND efaPP.account_relationship = {$assetAccountIs}) | |||
| LEFT JOIN {$tempTableName1} tpi | |||
| ON ft.payment_instrument_id = tpi.instrument_id | |||
| WHERE ft.fee_amount IS NOT NULL AND ft.fee_amount != 0 AND (con.contribution_status_id IN (%1, %3) OR (con.contribution_status_id =%2 AND con.is_pay_later = 1)) | |||
| GROUP BY con.id"; | |||
| WHERE ft.fee_amount IS NOT NULL AND ft.fee_amount != 0 AND (con.contribution_status_id IN (%1, %3) OR (con.contribution_status_id =%2 AND con.is_pay_later = 1))"; | |||
There was a problem hiding this comment.
I am not sure if changing from the single group by to a distinct here will cause issues @JoeMurray @monishdeb thoughts?
|
I agree with the patch and it works for me. Hence merging it. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21364 Fix upgrades from 4.2.x for ONLY_FULL_GROUP_BY compatability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades from 4.2.x fail because of issues with ONLY_FULL_GROUP_BY comparability. This fixes them. See https://test.civicrm.org/job/CiviCRM-Core-Matrix/CIVIVER=master,label=ubuntu1604/4347/testReport/junit/(root)/CivicrmUpgradeTest/4_2_0_setupsh_sql_bz2/ and https://test.civicrm.org/job/CiviCRM-Core-Matrix/CIVIVER=master,label=ubuntu1604/4347/testReport/junit/(root)/CivicrmUpgradeTest/4_2_16_setupsh_sql_bz2/ for evidence of failure. @monishdeb can i get you to review this because i'm not 100% sure about the financial stuff also ping @JoeMurray @eileenmcnaughton