Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-21357: Batch Data Entry: Added default start date on membership batch entry form #11202

Merged
merged 1 commit into from
Nov 3, 2017
Merged

CRM-21357: Batch Data Entry: Added default start date on membership batch entry form #11202

merged 1 commit into from
Nov 3, 2017

Conversation

Edzelopez
Copy link
Contributor

Overview

This PR adds a default start date to the membership bulk entry form when the contact is selected.

Before

Start date is set to NULL

After

Start date is retained.

@Edzelopez
CRM-21357 Added default start date on membership batch entry form
cefa366 
----------------------------------------
* CRM-21357: Start date is NULL when membership batch entry is processed
  https://issues.civicrm.org/jira/browse/CRM-21357
@Edzelopez Edzelopez changed the title CRM-21357 Added default start date on membership batch entry form [ready for review] CRM-21357 Added default start date on membership batch entry form Oct 26, 2017
@Edzelopez Edzelopez changed the title [ready for review] CRM-21357 Added default start date on membership batch entry form CRM-21357 Added default start date on membership batch entry form Oct 26, 2017
@monishdeb monishdeb changed the title CRM-21357 Added default start date on membership batch entry form CRM-21357: Added default start date on membership batch entry form Oct 26, 2017
agilewarealok
agilewarealok approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@agilewarealok agilewarealok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've tested this PR and it's working as expected. Looks good to merge.

@mlutfy
Copy link
Member

mlutfy commented Nov 3, 2017

I tested and seems OK.

  • Created a membership join_date 2016, start date 2017
  • Followed the steps to do a batch entry.
  • before the patch: start date was empty
  • after the patch: start date was set to the value of the first selected member.

@mlutfy mlutfy merged commit 7314917 into civicrm:master Nov 3, 2017
@mlutfy mlutfy changed the title CRM-21357: Added default start date on membership batch entry form CRM-21357: Batch Data Entry: Added default start date on membership batch entry form Nov 3, 2017
@monishdeb monishdeb deleted the CRM-21357 branch November 3, 2017 13:09
@monishdeb
Copy link
Member

Thanks @mlutfy :)

@jitendrapurohit jitendrapurohit mentioned this pull request Dec 28, 2017
Closed
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
@mlutfy @sluc23
Merge pull request civicrm#11202 from JMAConsulting/CRM-21357
02912af 
CRM-21357: Added default start date on membership batch entry form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilewarealok agilewarealok agilewarealok approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Edzelopez @mlutfy @monishdeb @agilewarealok @civicrm-builder