CRM-18048: keep civicrm_value table names to a minimum length to avoid report errors

CRM/Core/BAO/CustomGroup.php

@@ -189,7 +189,7 @@ public static function create(&$params) {
     $group->save();
     if (!isset($params['id'])) {
       if (!isset($params['table_name'])) {
-        $munged_title = strtolower(CRM_Utils_String::munge($group->title, '_', 42));
+        $munged_title = strtolower(CRM_Utils_String::munge($group->title, '_', 13));
         $tableName = "civicrm_value_{$munged_title}_{$group->id}";
       }
       $group->table_name = $tableName;

tests/phpunit/CRM/Report/Form/ActivityTest.php

@@ -0,0 +1,85 @@
+<?php
+/*
+ +--------------------------------------------------------------------+
+ | CiviCRM version 4.7                                                |
+ +--------------------------------------------------------------------+
+ | Copyright CiviCRM LLC (c) 2004-2017                                |
+ +--------------------------------------------------------------------+
+ | This file is a part of CiviCRM.                                    |
+ |                                                                    |
+ | CiviCRM is free software; you can copy, modify, and distribute it  |
+ | under the terms of the GNU Affero General Public License           |
+ | Version 3, 19 November 2007 and the CiviCRM Licensing Exception.   |
+ |                                                                    |
+ | CiviCRM is distributed in the hope that it will be useful, but     |
+ | WITHOUT ANY WARRANTY; without even the implied warranty of         |
+ | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.               |
+ | See the GNU Affero General Public License for more details.        |
+ |                                                                    |
+ | You should have received a copy of the GNU Affero General Public   |
+ | License and the CiviCRM Licensing Exception along                  |
+ | with this program; if not, contact CiviCRM LLC                     |
+ | at info[AT]civicrm[DOT]org. If you have questions about the        |
+ | GNU Affero General Public License or the licensing of CiviCRM,     |
+ | see the CiviCRM license FAQ at http://civicrm.org/licensing        |
+ +--------------------------------------------------------------------+
+ */
+
+/**
+ *  Test Activity report outcome
+ *
+ * @package CiviCRM
+ */
+class CRM_Report_Form_ActivityTest extends CiviReportTestCase {
+  protected $_tablesToTruncate = array(
+    'civicrm_contact',
+    'civicrm_email',
+    'civicrm_phone',
+    'civicrm_address',
+    'civicrm_contribution',
+  );
+
+  public function setUp() {
+    parent::setUp();
+    $this->quickCleanup($this->_tablesToTruncate);
+  }
+
+  public function tearDown() {
+    parent::tearDown();
+    CRM_Core_DAO::executeQuery('DROP TEMPORARY TABLE IF EXISTS civireport_contribution_detail_temp1');
+    CRM_Core_DAO::executeQuery('DROP TEMPORARY TABLE IF EXISTS civireport_contribution_detail_temp2');
+    CRM_Core_DAO::executeQuery('DROP TEMPORARY TABLE IF EXISTS civireport_contribution_detail_temp3');
+  }
+
+  /**
+   * Ensure long custom field names don't result in errors.
+   */
+  public function testLongCustomFieldNames() {
+    // Create custom group with long name and custom field with long name.
+    $long_name = 'this is a very very very very long name with 65 characters in it';
+    $group_params = array(
+      'title' => $long_name,
+      'extends' => 'Activity',
+    );
+    $result = $this->customGroupCreate($group_params);
+    $custom_group_id = $result['id'];
+    $field_params = array(
+      'custom_group_id' => $custom_group_id,
+      'label' => $long_name,
+    );
+    $result = $this->customFieldCreate($field_params);
+    $custom_field_id = $result['id'];
+    $input = array(
+      'fields' => array(
+        'custom_' . $custom_field_id,
+      ),
+    );
+    $obj = $this->getReportObject('CRM_Report_Form_Activity', $input);
+    //$params = $obj->_params;
+    //$params['fields'] = array('custom_' . $custom_field_id);
+    //$obj->setParams($params);
+    $obj->getResultSet();
+    $this->assertTrue(TRUE, "Testo");
+  }
+
+}

tests/phpunit/CiviTest/CiviReportTestCase.php

@@ -52,6 +52,28 @@ public function tearDown() {
    * @throws Exception
    */
   public function getReportOutputAsCsv($reportClass, $inputParams) {
+
+    $reportObj = $this->getReportObject($reportClass, $inputParams);
+    try {
+      $rows = $reportObj->getResultSet();
+      $tmpFile = $this->createTempDir() . CRM_Utils_File::makeFileName('CiviReport.csv');
+      $csvContent = CRM_Report_Utils_Report::makeCsv($reportObj, $rows);
+      file_put_contents($tmpFile, $csvContent);
+    }
+    catch (Exception $e) {
+      throw $e;
+    }
+    return $tmpFile;
+  }
+
+  /**
+   * @param $reportClass
+   * @param array $inputParams
+   *
+   * @return array
+   * @throws Exception
+   */
+  public function getReportObject($reportClass, $inputParams) {
     $config = CRM_Core_Config::singleton();
     $config->keyDisable = TRUE;
     $controller = new CRM_Core_Controller_Simple($reportClass, ts('some title'));
@@ -83,11 +105,6 @@ public function getReportOutputAsCsv($reportClass, $inputParams) {
     try {
       $reportObj->storeResultSet();
       $reportObj->buildForm();
-      $rows = $reportObj->getResultSet();
-
-      $tmpFile = $this->createTempDir() . CRM_Utils_File::makeFileName('CiviReport.csv');
-      $csvContent = CRM_Report_Utils_Report::makeCsv($reportObj, $rows);
-      file_put_contents($tmpFile, $csvContent);
     }
     catch (Exception $e) {
       // print_r($e->getCause()->getUserInfo());
@@ -96,7 +113,7 @@ public function getReportOutputAsCsv($reportClass, $inputParams) {
     }
     CRM_Utils_GlobalStack::singleton()->pop();
 
-    return $tmpFile;
+    return $reportObj;
   }
 
   /**

tests/phpunit/CiviTest/CiviUnitTestCase.php

@@ -2074,10 +2074,6 @@ public function customGroupCreate($params = array()) {
 
     $params = array_merge($defaults, $params);
 
-    if (strlen($params['title']) > 13) {
-      $params['title'] = substr($params['title'], 0, 13);
-    }
-
     //have a crack @ deleting it first in the hope this will prevent derailing our tests
     $this->callAPISuccess('custom_group', 'get', array(
       'title' => $params['title'],