CRM-21272: move definition of isPasswordUserGenerated to CMS classes #11145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eileenmcnaughton please check. |
|
@herbdool Herb can you fix the style issues https://test.civicrm.org/job/CiviCRM-Core-PR/17641/checkstyleResult/new/ |
|
@seamuslee001 better |
|
looks good - tagging @jackrabbithanna @dsnopek in case they want to eyeball the drupal parts |
|
Jenkins re test this please |
|
I haven't actually tested it, but just looking at the code, the Drupal bits (both 8 and 6 & 7) look good! |
|
Thanks @dsnopek I feel confident to merge this based on reading the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #11079 -- ensuring CMS logic in CMSUser.php is in CMS classes to keep it clean and extendable.