Navigation - Fix serialization error #11107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview -------- The navigation subsystem stores per-user data in the table `civicrm_setting`. Most access to this table goes through `CRM_Core_BAO_Setting` or `Civi\Core\SettingsBag`. However, certain edge-cases produce a warning about a serialization error because `CRM_Core_BAO_Navigation` does not participate. Before ------ `CRM_Core_BAO_Navigation::resetNavigation()` generates malformed records which cannot be read via `CRM_Core_BAO_Setting` or `Civi\Core\SettingsBag`. After ----- `CRM_Core_BAO_Navigation::resetNavigation()` generates better records.
|
SO we make this change & it still generates malformed messages? |
|
@eileenmcnaughton Thanks, that was a mistake in the description. (Fixed now.) After the change, it should make well-formed records in |
|
Tested & works for me. |
|
Merging based on @aydun testing, minor code change with constrained impact |
|
But, I don't think this should have gone without a JIRA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The navigation subsystem stores per-user data in the table
civicrm_setting. Most access to this table goes throughCRM_Core_BAO_SettingorCivi\Core\SettingsBag. However, certainedge-cases produce a warning about a serialization error because
CRM_Core_BAO_Navigationdoes not participate.Before
CRM_Core_BAO_Navigation::resetNavigation()generates malformedrecords which cannot be read via
CRM_Core_BAO_SettingorCivi\Core\SettingsBag.After
CRM_Core_BAO_Navigation::resetNavigation()generates well-formedrecords which can be read via
CRM_Core_BAO_SettingorCivi\Core\SettingsBag.