CRM-21282 Improve ordering of click reporting

[JKingsnorth]

Overview

The list of links on the click report summary, on the mailing overview page, didn't display links in a sensible order.

Before

The links are basically in a random order.

After

The links are ordered from highest clicks to lowest clicks.

Technical Details

Changes to the 'ORDER BY' clause in the SQL that builds the list.

---

• CRM-21282: Improve ordering of CiviMail click reporting

[highfalutin]

Reviewing.

[JKingsnorth]

@highfalutin Hope the review went OK, let me know =]

[highfalutin]

The PR works as described, appears safe, and seems like a worthwhile improvement. @eileenmcnaughton, care to merge?

[eileenmcnaughton]

Thanks for the review @highfalutin - I think that is adequate for this change

[highfalutin]

PS, this was the script I used to create a mailing containing links and "send" it (to log file) so I could trigger the link tracking and see the results in the link tracking report. Executed it with cv php:script --user admin create_and_send_mailing_with_links.php.

<?php
if (!defined('CIVICRM_MAIL_LOG')) {
  define('CIVICRM_MAIL_LOG', CIVICRM_TEMPLATE_COMPILEDIR . '/mail.log');
}

civicrm_api3('MailSettings', 'create', array(
  'id' => 1,
  'domain_id' => 1,
  'name' => 'default',
  'is_default' => 1,
  'domain' => "test.civi",
  'localpart' => "test",
));

$mailing_result = civicrm_api3('Mailing', 'create', array(
  'sequential' => 1,
  'name' => "Click tracking report ordering test",
  'subject' => "Click tracking report ordering test",
  'body_text' => "Here is a link to Google: http://google.com. \n" .
  "Here is a link to The New York Times: http://nytimes.com. \n" .
  "And here is one to CiviCRM: http://civicrm.org.\n",
  'url_tracking' => 1,
  'is_completed' => 0,
  'groups' => array('include' => array(4)),
  'api.Mailing.submit' => array(
	  'scheduled_date' => "2017-10-10 12:11:40",
	  'approval_date' => "2017-10-10 12:11:40",
	)
));

$result = civicrm_api3('Job', 'process_mailing', array());
print_r($result);
print CIVICRM_MAIL_LOG;

[JKingsnorth]

Thanks, both, and thanks @highfalutin for sharing that snippet!