CRM-21245: Incorrect Contribution status 'Pending Refund'

[monishdeb]

Overview

Steps to replicate:
If the participant is registered to an event by admin in backend and event has 3 selections:

1. 1st - $1500.00
2. 2nd - $1200.00
   At first '1st' selection was made and partial payment of $500.00 was made, then event participation summary is viewed, it shows correct status. Screenshot: http://prntscr.com/gsfokn
   Now when selection is changed to '2nd' still contact owes $700 but system says the payment status to be "Pending refund". Screenshot: http://prntscr.com/gsfpgg

Before

Contribution status is updated to 'Pending Refund' - Incorrect.
https://www.screencast.com/t/cOfGhsHgQJe

After

Contribution status is retained to 'Partially Paid' - Correct.

---

• CRM-21245: Incorrect Contribution status "Pending Refund"

[monishdeb]

Added, unit test is supposed to fail as it depends on #10962. Reason why I am marking it with [WIP]

[monishdeb]

@eileenmcnaughton this PR is ready for QA and also got unit tests.

[eileenmcnaughton]

There is a lot to like about this PR. It simplifies code, adds a test & fixes a problem!

I think the fact that this was fixed through simplifying & relying on the fee change logic speaks to the fact the previous changes in this area were on the right track.

Merging

[agh1]

It appears that the reverse problem is now happening in the 4.7.30 RC. If you create a participant record with a partial payment, and you edit the selections for the participant record to be the same or lower amount than the payments, the participant record still says "partially paid" when it should be "completed" or "pending refund".

[monishdeb]

@agh1 isn't that obvious because the original amount was partial and after edit we are not paying rest but rather keeping the same partial amount or lower then it, which is itself a partial amount?

@eileenmcnaughton what do you think?

[eileenmcnaughton]

So on this form (yay) we can edit the amount to be paid and the amount paid separately.

We should be calculating payment status by what portion of the amount has been paid

paid < due = 'Partially paid'
paid = due = 'Completed'
paid > due = 'Pending refund'

THis is REALLY late in the rc to pick this up - my sense is it's obscure enough to review for 4.7.31 rather than revert + review for 4.7.31? (@agh1 )

[agh1]

Yeah, I wasn't proposing changing anything for 4.7.30--sorry I wasn't clear. I do think this fixes a bug; it just causes a slightly less likely one in the process.

Here's the workflow I was trying:

1. Register someone for the Rainforest Cup at $1,500 and pay only $1,200.
2. Change the fee selection to be $1,000.
3. It should say "pending refund" at this point, but it now says "partially paid".

Another issue (maybe separate) is in the process when I try to record a partial payment from the backend, I get the following popup message:

Payment amount is less than the amount owed. Expected participant status is 'Partially paid'. Are you sure you want to set the participant status to ? Click OK to continue, Cancel to change your entries.

This is the case regardless of what the participant status is.

[pradpnayak]

@agh1 According to your workflow the contribution status should be 'Pending refund' since you have already paid $1,200 and you have updated the line item so that the total amount is now $1,000. Therefore the contribution status should be 'Pending refund' with $200.

[eileenmcnaughton]

@agh1 @pradpnayak @monishdeb looks like the behaviour is agreed & there is a bug remaining so perhaps open a new ticket for it?

[monishdeb]

Yup will submit a separate PR for that. @agh1 can you please create a new ticket?