CRM-21241 Logo improvements #11046
Merged
CRM-21241 Logo improvements #11046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-21241: Spinning logo is too jumpy https://issues.civicrm.org/jira/browse/CRM-21241
---------------------------------------- * CRM-21243: Logo in WP menu doesn't follow standard https://issues.civicrm.org/jira/browse/CRM-21243y
…color ---------------------------------------- * CRM-21241: Spinning logo is too jumpy https://issues.civicrm.org/jira/browse/CRM-21241
|
@tommybobo this is a favor for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The spinning CiviCRM logo in the top menu is bumpy and annoying. Also, the spinning logo as modals load is too fast and jittery.
This also removes a file used only in WordPress sites. civicrm/civicrm-wordpress#118 should be merged first--it removes the references to it.
Before
After
Technical Details
The menu logo was given both
fa-spinandfa-pulseclasses. The latter makes it rotate in steps rather than turning smoothly. The new GIF for modals now has more steps and moves more slowly among them.