CRM-21231: On CiviMail screen make 'Review and Schedule' tab active if required fields are filled

[monishdeb]

Overview

The Review and Schedule tab selector becomes active after the user first visits the Review and Schedule screen by clicking the Next button on the Define Mailing screen. It would be preferable for the tab to behave like the next button - become active when all the required fields are completed.

Before

The second tab is disabled even if all required fields are filled. Screencast:

After

The second tab is enabled after all required fields are filled.

NOTE: Clear cache before testing.

---

• CRM-21231: On CiviMail screen make 'Review and Schedule' tab active if required fields are filled

[mlutfy]

As a user, we reviewed this patch on the test site created by Jenkins, and it looks good. Tested filling in the mandatory fields, reloading the screen and comparing with the current dmaster site.

However, there are failing tests.

(we are doing review/demo in a sprint)

[mlutfy]

jenkins, test this please

[monishdeb]

Jenkin test this please

[lcdservices]

tested and this is working as expected.

[seamuslee001]

@monishdeb i tested this on a local dmaster. This looks good for when you have filled in all the fields. I agree this is a good improvement. I also noticed that the tab stayed active when i removed a required field e.g. Subject after it was made active. I think we may just need to check that its also watching for changes

[monishdeb]

@seamuslee001 I have updated the PR, can you please check now?

[lcdservices]

@monishdeb @seamuslee001 just ran a test and it now watches for changes -- if the data in a required field is removed, the link is disabled. I think this is good to go.

[monishdeb]

Thank you @mlutfy @seamuslee001 @lcdservices for your feedback :)

@eileenmcnaughton / @colemanw can you please merge this PR?