CRM-21198: Completing payment for partially paid membership doesn't change membership status #10999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange membership status
|
@eileenmcnaughton I have extracted one of the fixes included in #10352 patch onto a separate issue. Unfortunately, I cannot add the UT for this fix as it has some dependencies on original issue CRM-20569 |
|
@monishdeb I commented on that PR that I thought it makes sense to extract & share code from completeOrder - I put this up to make it clearer what I mean - it doesn't go the full way. |
| @@ -3820,6 +3820,15 @@ public static function recordAdditionalPayment($contributionId, $trxnsData, $pay | |||
| $participantId = CRM_Core_DAO::getFieldValue('CRM_Event_DAO_ParticipantPayment', $contributionId, 'participant_id', 'contribution_id'); | |||
| } | |||
|
|
|||
| // fetch membership IDs registered against given contribution ID | |||
There was a problem hiding this comment.
I deeply loath this function, but I think we should it in order to be as aligned with the completeOrder function as possible
loadRelatedMembershipObjects(&$ids)
- then lower down we can call the same function
|
Closing in favor of #11006 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Steps to replicate:
Result
Related contribution's status is changed to 'Completed' from 'Partially paid' - correct
Related membership's status didn't change and still set to 'Pending' - incorrect
Before
Related membership's status isn't changed to New
After
Membership's status isn't changed to Completed