Fix for CRM-21122: "Support selection of smart groups on Contact Dashboard"

[twomice]

Overview

Changes the Contact Dashboard so that the user can join and leave publicly visible Smart Groups, just as they can on Profiles, as shown in this Profile screenshot:

Before

Without this change, all Smart Groups are excluded from the Contact Dashboard, as shown here:

After

After this change, Smart Groups which are publicly visible are shown for joining and leaving on the Contact Dashboard, just as on Profiles, as shown here:

Technical Details

• Besides the Contact Dashboard, this PR touches code that builds the list of groups in other contexts, such as the "Groups" tab on a Contact record. Here's a screenshot of that tab, with this code change in place; note the proper display of all groups, both smart and non-smart, both public and non-public.
  

Comments

Nothing of note.

---

• CRM-21122: Support selection of smart groups on Contact Dashboard

[eileenmcnaughton]

There is a fatal error in the test

PHP Fatal error: Call to undefined function array_column() in /home/jenkins/buildkit/build/core-10925-6mvfq/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/Page/View/UserDashboard/GroupContactTest.php on line 120
RUN:[[./scripts/phpunit --tap --log-junit '/home/jenkins/workspace/CiviCRM-Core-PR/junit/api_v3_AllTests.xml' '--exclude-group' 'ornery' 'api_v3_AllTests']]

Other than that @seamuslee001 do you want to put this through it's paces on performance?

[twomice]

Curse you, php 5.3. You haven't heard the last of me!

[twomice]

No more array_column(). Test are passing. Take that, php 5.3!

[totten]

You show em, @twomice! Show PHP 5.3 how real programmers vectorize the column of a multi-dimensional array!

[totten]

Aside: There's also CRM_Utils_Array::collect().

[twomice]

Jenkins test this please.

[twomice]

Thanks for the tip, @totten -- I'll buy that for a dollar. I should have guessed CRM_Utils_Array would have something.

[eileenmcnaughton]

Php is beaten into submission. This generally looks good but I would very much like @seamuslee001 to test it with their data as I'd like to be sure there is not a performance issue with groups. @systopia or @jaapjansma might have data sets worth testing on - or @davejenx

[monishdeb]

@eileenmcnaughton @twomice I have a doubt - Does Civi retain manually added a contact in a smart group when contact-cache is rebuilt based on saved search criteria?

[davejenx]

@monishdeb As a general point, manually added contacts in a smart group should be retained when group_contact_cache is rebuilt, because the manually added/removed contacts are stored in group_contact. I'm sure you know that, so is your question whether the manually added contacts are also in group_contact_cache? Or is it a question specific to the code changes in this PR?

[monishdeb]

@davejenx thanks for your reply. Sorry to put this silly question w/o doing enough research on my end.

Will provide my feedback about this PR soon.

[seamuslee001]

I tested this on an AUG install, I didn't see any obvious performance issues and i was able to confirm it now allows for public smart groups to show in the list. I think this is good to be merged

[twomice]

@eileenmcnaughton or @monishdeb , any possibility to merge this in based on Seamus's review?

[monishdeb]

Works fine in my local and from code pov its ok to merge.

[twomice]

Thanks @monishdeb !