CRM-21100 Hotfix to ensure that testGroup list is still the same as p… #10895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revious, need to work on converting to AJAX list
seamuslee001
force-pushed
the
CRM-21100-rc
branch
from
bd4b83d to
31815c2
Compare
|
👍 Tested on 4.7.24-RC and works for me. |
|
Good to merge per @mlutfy testing |
totten
added a commit
to totten/uk.co.vedaconsulting.mosaico
that referenced
this pull request
Nov 27, 2017
Upstream made some changes in how the list of groups is supplied (CRM-21100, circa v4.7.24). This patch ports the change from civicrm/civicrm-core#10895. Note the use of `CRM.crmMailing.testGroupNames || CRM.crmMailing.groupNames` is intended to provide compatibility with older and newer protocols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…revious, need to work on converting to AJAX list
Overview
With Changes made in CRM-20521 this changed how the groupNames variable was constructed to be more dynamic. This had the unintended consequence of limiting the test group list. This resurrects the test group list as it was before. This should be properly fixed later.
ping @mlutfy