CRM-21075 Replace call to CRM_Core_OptionGroup::getValue with CRM_Cor… #10878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_PseudoConstant::getKey in CommunicationsPreferences edit
|
This looks right to me (not yet tested myself), but, why is this against the rc? |
|
@eileenmcnaughton Joe felt that it should be against the RC as per chat in dev-postrelease but happy to shift to master if that is the consensus |
|
I don't feel this meets the criteria - it's not a regression, it does not affect properly configured production sites & it is not critical |
|
I just tested this against master & am ready to merge it against master. I created a contact using the 'new individual' block & witnessed the error messages. After applying the patch the messages did not appear. Crucially the greeting fields were populated the same on the 2 contacts created - per screenshot
|
|
@eileenmcnaughton this has passed testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e_PseudoConstant::getKey in CommunicationsPreferences edit
Overview
When a user would edit their record, a series of notices would be generated because of use of a deprecated function. This no longer happens.
Before
Notices appear about use of deprecated function
After
Notices do not appear anymore. I have tested this on a local buildkit install and appears to work as expected.
@JoeMurray @eileenmcnaughton @totten does this look right?