CRM-21061 - Fix rare report error when the report name is longer than 64 Char #10854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue Change civicrm_report_instance, report_id from 64 characters to 512 characters to match civicrm_option_value, value to avoid errors caused by truncating CiviCRM report name which are greater than 64 chars. https://issues.civicrm.org/jira/browse/CRM-21061
Regenerate DAOs and Upgrade step to fix current installs
|
@eileenmcnaughton this makes sense to me. There doesn't seem a reason why these should differ quiet as dramatically. |
|
Agree. Thanks @agileware @seamuslee001 |
eileenmcnaughton
changed the title
This was referenced Oct 19, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Change civicrm_report_instance, report_id from 64 characters to 512 characters to match civicrm_option_value, value to avoid errors caused by truncating CiviCRM report name which are greater than 64 chars.
See https://issues.civicrm.org/jira/browse/CRM-21061
Before
64 character limit causes report_id to be truncated for long report names and incorrect value stored.
After
Increase to 512 character limit which should reduce the likelihood report name is truncated.
Technical Details
Change report_id to 512 varchar
Comments
There could possibly be better error reporting to avoid this situation and inform developers of long report names potentially causing an issue. See https://issues.civicrm.org/jira/browse/CRM-21061