CRM-20995 - API - Extension get - Filter by full_name #10796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-20995: API - Extension get - Ignores parameter full_name as created by API explorer https://issues.civicrm.org/jira/browse/CRM-20995
|
I haven't had a chance to try this, but kudos on general form -- unit-test, before/after, and so on. :) |
colemanw
requested changes
Jul 31, 2017
api/v3/Extension.php
Outdated
| function _civicrm_api3_getKeys($params) { | ||
| if (is_array($params['keys'])) { | ||
| return $params['keys']; | ||
| function _civicrm_api3_getKeys($params, $key) { |
There was a problem hiding this comment.
I suggest giving the default value 'keys' to the 2nd param in this function signature, to better guerantee backward compatibility. Then you won't have to change the function call everywhere and as a side benefit this PR will be smaller/simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-20995
Overview
This PR allows to filter Extensions by full_name as generated by API explorer.
Before
After
Technical Details
It seems a bit confusing to have full_name, key, and keys all refering to the same DAO field full_name.
This PR merges the two parameters full_name and keys to the already used one named keys.
Comments
Almost all parameter and return fields seem to be currently ignored.